Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup global variable declarations #38410

Merged
merged 1 commit into from May 24, 2023
Merged

refactor: cleanup global variable declarations #38410

merged 1 commit into from May 24, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 23, 2023 •
edited

Declare the globals for each init separately. Also reuse WebViewImplHooks for isolatedApi type

electron/lib/renderer/web-view/web-view-impl.ts

Lines 14 to 18 in e7b8bb4

export interface WebViewImplHooks {
readonly guestViewInternal: typeof guestViewInternalModule;
readonly allowGuestViewElementDefinition: NodeJS.InternalWebFrame['allowGuestViewElementDefinition'];
readonly setIsWebView: (iframe: HTMLIFrameElement) => void;
}

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 23, 2023
@miniak miniak force-pushed the miniak/cleanup-duplicate-isolated-api-type branch from fe9db04 to abd328e Compare May 23, 2023 14:48
@miniak miniak changed the title refactor: eliminate duplicate isolatedApi typing refactor: cleanup global variable declarations May 23, 2023
@miniak miniak force-pushed the miniak/cleanup-duplicate-isolated-api-type branch from abd328e to be7550f Compare May 23, 2023 14:49
@miniak miniak self-assigned this May 23, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport semver/none and removed semver/patch backwards-compatible bug fixes labels May 23, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 24, 2023
@codebytere codebytere merged commit a043a60 into main May 24, 2023
16 checks passed
@codebytere codebytere deleted the miniak/cleanup-duplicate-isolated-api-type branch May 24, 2023 18:01
@release-clerk
Copy link

release-clerk bot commented May 24, 2023

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Aug 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @codebytere