fix: sync api::Screen wrapper method sigs to upstream #38597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui::Display GetAllDisplays(), GetPrimaryDisplay(), GetDisplayMatching(), and GetDisplayNearestPoint() methods are all const, so make our wrappers const too. ui::Display GetAllDisplays() returns a const reference, so make our wrapper return a const reference too. This avoids creating a new std::vector<display::Display> each time it's called.
ckerr
added
semver/patch
dsanders11
approved these changes
Jun 6, 2023
zcbenz
approved these changes
Jun 6, 2023
codebytere
approved these changes
Jun 6, 2023
codebytere
deleted the
refactor/match-api-screen-display-accessor-signatures-to-ui-display-counterparts
branch
|
No Release Notes |
|
I have automatically backported this PR to "24-x-y", please check out #38631 |
trop
bot
added
in-flight/24-x-y
and removed
target/24-x-y
This was referenced Jun 7, 2023
|
I have automatically backported this PR to "25-x-y", please check out #38632 |
|
I have automatically backported this PR to "26-x-y", please check out #38633 |
trop
bot
added
in-flight/26-x-y
merged/26-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Sync the signatures of the
api::Screen's Display wrappers to match theui::Displaymethods that they wrap:GetAllDisplays()const and return a const reference. Currently we're always returning a new vector.GetPrimaryDisplay()constGetDisplayNearestPoint()constGetDisplayMatching()constChecklist
npm testpassesRelease Notes
Notes: none