[Bug]: showSaveDialog without filters, changing name on windows drops extension

[jamiebuilds-signal]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

25.1.0

What operating system are you using?

Windows

Operating System Version

Windows 10, version 19041.1415

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

const { filePath } = await dialog.showSaveDialog({ defaultPath: "change-me.txt" })
// presented as "change-me" -- change to "updated-name"
console.log(filePath) // >> "updated-name.txt"

Actual Behavior

const { filePath } = await dialog.showSaveDialog({ defaultPath: "change-me.txt" })
// presented as "change-me" -- change to "updated-name"
console.log(filePath) // >> "updated-name" (no extension)

Testcase Gist URL

https://gist.github.com/jamiebuilds/4731be0aa643774a71e4543a572f753f

Additional Information

• It's not always possible to create a filter for every possible file extension you could be saving
• It's difficult to deal with paths like .tar.gz in user land

[deermichel]

IMO this is intended behavior on Windows. If you save a file with type All Files, that extension can be anything. The effect becomes even more obvious when you enable "show file name extensions". I agree this is cumbersome, but the solution might be to verify/append the extension in your code as needed.

[jamiebuilds-signal]

I'm not sure what the expected behavior for Windows users would be if it were being appended.

• What happens if they provide their own extension that wasn't intended? file.mov -> file.mp4 or file.jpeg -> file.wrong
• What should be presented if you have multiple extensions? file.tar.gz or file.html.md
  • Right now if you pass file.tar.gz the prompt shows file.tar, should you trim that off completely?
• What happens if they used an alias of the file extension .jpeg -> .jpg or .js -> .mjs

One option is to ignore anything they enter as a file extension: https://gist.github.com/jamiebuilds/dbb1d7464e944a1b275df642cadd3aa1

I guess I don't know how that would come across to different windows users. If someone typed in their own file extension, would they expect that to be respected?

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[jamiebuilds-signal]

bump

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[jamiebuilds-signal]

bump