Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Native spellchecker only provides suggestions in one language when multiple languages are defined #38876

Open
3 tasks done
lishid opened this issue Jun 21, 2023 · 11 comments
Labels
25-x-y bug 🪲 component/spellcheck has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows

Comments

@lishid
Copy link
Contributor

lishid commented Jun 21, 2023

Preflight Checklist

Electron Version

25.1.1

What operating system are you using?

Windows

Operating System Version

Windows 10 22H2

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

dictionarySuggestions should give suggestions for the misspelled word in the correct language that detected the misspelling.

Actual Behavior

dictionarySuggestions only give suggestions in the last language in the spellcheck languages.

Testcase Gist URL

https://gist.github.com/8c67d602682b4203906c60c89036b311

Additional Information

In this example, the corrections should include "example"
image

@Jelmerro
Copy link

Jelmerro commented Jun 23, 2023

It seems to not be so much related to multiple languages, as that does work if you only add languages without a dash in them, for example nl, de works on the Windows machine here and suggests words in both languages, while en-GB, en-US doesn't suggest anything. I believe this is the issue that documents this behavior: #28684 Basically, just the English dictionaries haven't worked on Windows for the last x years, it's not related to the amount of dictionaries in the list.

@lishid
Copy link
Contributor Author

lishid commented Jun 23, 2023

The English dictionary works perfectly fine if there is not another language set:

image
image

@lishid
Copy link
Contributor Author

lishid commented Jun 23, 2023

Here are more cases:

With ['en-US', 'de']:
image

With ['de', 'en']:
image

@Jelmerro
Copy link

That is very weird, if I set it to de, en in that order, I ONLY get suggestions for German, but never for English.

@whitenoisedev
Copy link

Does this work in Chrome/Win?

@Jelmerro
Copy link

Jelmerro commented Jun 28, 2023

In Chromium at least I can barely get it to work either, most of the time it doesn't even show the red lines in there, so in that respect Electron is much faster and more consistent, except that English suggestions are basically never shown. On Windows that is, other systems all work fine in both Chromium and Electron.

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@whitenoisedev
Copy link

bump

@georgexu99 georgexu99 added the has-repro-gist Issue can be reproduced with code at https://gist.github.com/ label Oct 3, 2023
@trevorTB
Copy link

trevorTB commented Nov 1, 2023

bump

2 similar comments
@xDEADC0DE
Copy link

bump

@xppx99
Copy link

xppx99 commented Feb 20, 2024

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y bug 🪲 component/spellcheck has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows
Projects
No open projects
Status: Does Not Block Stable
Development

No branches or pull requests

8 participants