feat: add support for keyboard initialized menu popup #38903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
semver/minor
erickzhao
reviewed
Jun 22, 2023
Co-authored-by: Erick Zhao <erick@hotmail.ca>
VerteDinde
approved these changes
Jun 27, 2023
clavin
approved these changes
Jun 27, 2023
zcbenz
approved these changes
Jun 27, 2023
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
|
The code change was +1'ed upstream so landing here https://chromium-review.googlesource.com/c/chromium/src/+/4656821 |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "26-x-y", please check out #38954 |
trop
bot
added
in-flight/26-x-y
merged/26-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* feat: add support for keyboard initialized menu popup * Update docs/api/menu.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * fix: add patch to chromium for keyboard accessibility menu behavior * refactor: s/initiatedByKeyboard/sourceType * fix: ignore initial mouse event to retain keyboard initiated focus * Update docs/api/menu.md Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com> --------- Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves some accessibility issues with
menu.popupfor keyboard nav accessibility usersThis PR also floats a patch that I intend to upstream. Chrome does not follow standard accessibility behaviour currently (when compared to native menus and even the //views implementation of menus that Edge uses) so this patch should go upstream to benefit all screen reader users too 馃憤
Notes: Added support for flagging a Menu as being keyboard initiated