New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() #38929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/object-has-own
branch
from
June 26, 2023 19:23
8c76da1
to
9b7ce10
Compare
ppontes
approved these changes
Jun 26, 2023
zcbenz
approved these changes
Jun 27, 2023
jkleinsc
approved these changes
Jun 27, 2023
No Release Notes |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
BurningEnlightenment
added a commit
to BurningEnlightenment/electron
that referenced
this pull request
Jan 18, 2024
zcbenz
pushed a commit
to BurningEnlightenment/electron
that referenced
this pull request
Feb 8, 2024
BurningEnlightenment
added a commit
to BurningEnlightenment/electron
that referenced
this pull request
Feb 14, 2024
jkleinsc
pushed a commit
that referenced
this pull request
Feb 16, 2024
* refactor(protocol): extract file stream factory Increase readability by moving the file stream creation logic out of the `uploadData` to request body conversion function. * fix: properly flatten streams in `protocol.handle()` Refs: #39658 * fix: `protocol.handle()` filter null origin header Refs: #40754 * fix: remove obsolete TODO comment Refs: #38929 * fix: forward `Blob` parts in `protocol.handle()` Refs: #40826 * fix: explicitly error out on unknown chunk parts
trop bot
added a commit
that referenced
this pull request
Feb 16, 2024
Refs: #38929 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
trop bot
added a commit
that referenced
this pull request
Feb 16, 2024
Refs: #38929 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
VerteDinde
pushed a commit
that referenced
this pull request
Feb 19, 2024
* refactor(protocol): extract file stream factory Increase readability by moving the file stream creation logic out of the `uploadData` to request body conversion function. Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> * fix: properly flatten streams in `protocol.handle()` Refs: #39658 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> * fix: `protocol.handle()` filter null origin header Refs: #40754 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> * fix: remove obsolete TODO comment Refs: #38929 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> * fix: forward `Blob` parts in `protocol.handle()` Refs: #40826 Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> * fix: explicitly error out on unknown chunk parts Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn
Notes: none