Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Object.prototype.hasOwnProperty() with Object.hasOwn() #38929

Merged
merged 1 commit into from Jun 27, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 26, 2023

@miniak miniak requested a review from a team as a code owner June 26, 2023 19:15
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 26, 2023
@miniak miniak self-assigned this Jun 26, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Jun 26, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 27, 2023
@jkleinsc jkleinsc merged commit 607e71d into main Jun 27, 2023
15 checks passed
@jkleinsc jkleinsc deleted the miniak/object-has-own branch June 27, 2023 20:57
@release-clerk
Copy link

release-clerk bot commented Jun 27, 2023

No Release Notes

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
BurningEnlightenment added a commit to BurningEnlightenment/electron that referenced this pull request Jan 18, 2024
zcbenz pushed a commit to BurningEnlightenment/electron that referenced this pull request Feb 8, 2024
BurningEnlightenment added a commit to BurningEnlightenment/electron that referenced this pull request Feb 14, 2024
jkleinsc pushed a commit that referenced this pull request Feb 16, 2024
* refactor(protocol): extract file stream factory

Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.

* fix: properly flatten streams in `protocol.handle()`

Refs: #39658

* fix: `protocol.handle()` filter null origin header

Refs: #40754

* fix: remove obsolete TODO comment

Refs: #38929

* fix: forward `Blob` parts in `protocol.handle()`

Refs: #40826

* fix: explicitly error out on unknown chunk parts
trop bot added a commit that referenced this pull request Feb 16, 2024
Refs: #38929

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
trop bot added a commit that referenced this pull request Feb 16, 2024
Refs: #38929

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
VerteDinde pushed a commit that referenced this pull request Feb 19, 2024
* refactor(protocol): extract file stream factory

Increase readability by moving the file stream creation logic out of the
`uploadData` to request body conversion function.

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

* fix: properly flatten streams in `protocol.handle()`

Refs: #39658

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

* fix: `protocol.handle()` filter null origin header

Refs: #40754

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

* fix: remove obsolete TODO comment

Refs: #38929

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

* fix: forward `Blob` parts in `protocol.handle()`

Refs: #40826

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

* fix: explicitly error out on unknown chunk parts

Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Henrik S. Gaßmann <BurningEnlightenment@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants