Add env var to export a hint file to optimize ASAR ordering #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
changed the title
| @@ -25,6 +25,12 @@ Starts the process as a normal Node.js process. | |||
|
|
|||
| Prints Chrome's internal logging to console. | |||
|
|
|||
| ## `ELECTRON_LOG_ASAR_READS` | |||
|
|
|||
| When Electron reads from an ASAR file, log the the read offset and file path | |||
|
Some asar resources are loaded from the c++ side (example). Will this code log them as well? |
|
Hey folks thanks for the feedback—sorry I dropped the ball on this one. I'll address those typos! @etiktin, this isn't currently logging resources loaded from the C++ side. I'm not sure if it's possible to log those to the same file, and ensure that they're written to the logged in the correct order... |
|
@bengotow Do you mind rebasing this on master branch? Recently we have converted all our CoffeeScript files to JavaScript. |
This is a work in progress—need to make this behavior optional via a new flag.
|
Glad to see everything is going to ES6. I've converted my changes to JS and updated the pull request. Also double-checked to make sure it still works correctly. |
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Jan 21, 2016
Add env var to export a hint file to optimize ASAR ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview here: atom/atom#10163