Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: render process: assert.ok(false) throws TypeError instead of AssertionError #39079

Closed
3 tasks done
ianhattendorf opened this issue Jul 12, 2023 · 0 comments · Fixed by #39540
Closed
3 tasks done
Assignees
Labels
25-x-y bug 🪲 component/node-integration platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@ianhattendorf
Copy link

Preflight Checklist

Electron Version

25.2.0

What operating system are you using?

Other Linux

Operating System Version

Fedora 38

What arch are you using?

x64

Last Known Working Electron version

11.1.0

Expected Behavior

AssertionError [ERR_ASSERTION]: false == true

Actual Behavior

TypeError: call.getFileName is not a function

Testcase Gist URL

https://gist.github.com/ianhattendorf/82aeba581323093882168ddf69b6c6c2

Additional Information

This broke a while back for both main + render processes (#24577) and was fixed in 11.0.0 (verified with fiddle). It later regressed, breaking for only render processes in 11.1.1.

v11.1.0...v11.1.1

@codebytere maybe you remember this from last time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y bug 🪲 component/node-integration platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
No open projects
Status: Unsorted Items
Development

Successfully merging a pull request may close this issue.

2 participants