Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document idleDetector permissions #39180

Merged
merged 1 commit into from
Jul 24, 2023
Merged

docs: document idleDetector permissions #39180

merged 1 commit into from
Jul 24, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Adds more descriptive and linked information for permission handlers as well as adds a missing idle-detection value alongside corresponding API tests.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Jul 21, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 21, 2023
@codebytere codebytere changed the title doc: document idleDetector permissions docs: document idleDetector permissions Jul 21, 2023
@VerteDinde
Copy link
Member

Oh, actually, it looks like the type changes may be legitimately causing some tests to fail here

@dsanders11
Copy link
Member

Yea, the typing change has uncovered a bug in the docs here - clipboard-read and clipboard-sanitized-write should also be listed for Session.setPermissionCheckHandler.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 22, 2023
@codebytere
Copy link
Member Author

@dsanders11 @VerteDinde corrected!

@jkleinsc jkleinsc merged commit 1231f0a into main Jul 24, 2023
17 checks passed
@jkleinsc jkleinsc deleted the idle-detection-api-doc branch July 24, 2023 18:57
@release-clerk
Copy link

release-clerk bot commented Jul 24, 2023

No Release Notes

This was referenced Jul 24, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 24, 2023

I have automatically backported this PR to "24-x-y", please check out #39212

@trop trop bot mentioned this pull request Jul 24, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 24, 2023

I have automatically backported this PR to "25-x-y", please check out #39213

@trop trop bot removed the target/24-x-y PR should also be added to the "24-x-y" branch. label Jul 24, 2023
@trop
Copy link
Contributor

trop bot commented Jul 24, 2023

I have automatically backported this PR to "26-x-y", please check out #39214

@trop trop bot added merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/24-x-y in-flight/26-x-y labels Jul 24, 2023
@commit-lint commit-lint bot mentioned this pull request Oct 2, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
docs: document idleDetector permissions (electron#39180)
22add0f 
doc: document idleDetector permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@miniak miniak Awaiting requested review from miniak

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @VerteDinde @dsanders11 @jkleinsc