Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use TypeError instead of generic Error when appropriate #39209

Merged
merged 1 commit into from Jul 25, 2023
Merged

refactor: use TypeError instead of generic Error when appropriate #39209

merged 1 commit into from Jul 25, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 24, 2023

@miniak miniak requested a review from a team as a code owner July 24, 2023 13:58
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2023
@miniak miniak changed the title refactor: use TypeError instead of generic Error when appropriate refactor: use TypeError instead of generic Error when appropriate Jul 24, 2023
@miniak miniak self-assigned this Jul 24, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Jul 24, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 25, 2023
@jkleinsc jkleinsc merged commit 455f573 into main Jul 25, 2023
16 checks passed
@jkleinsc jkleinsc deleted the miniak/type-error branch July 25, 2023 16:08
@release-clerk
Copy link

release-clerk bot commented Jul 25, 2023

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Oct 4, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
refactor: use TypeError instead of generic Error when appropriate (…
cda69db 
…electron#39209)

refactor: use TypeError instead of generic Error when appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @jkleinsc @codebytere @RaisinTen