fix: update chrome.i18n for Manifest v3
#39291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
3 tasks
codebytere
requested review from
jkleinsc
and removed request for
MarshallOfSound
zcbenz
approved these changes
Aug 2, 2023
|
Release Notes Persisted
|
|
I was unable to backport this PR to "24-x-y" cleanly; |
trop
bot
added
needs-manual-bp/24-x-y
and removed
target/24-x-y
This was referenced Aug 2, 2023
|
I have automatically backported this PR to "26-x-y", please check out #39328 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "25-x-y", please check out #39329 |
trop
bot
added
in-flight/25-x-y
and removed
target/25-x-y
trop
bot
added
merged/25-x-y
|
@codebytere has manually backported this PR to "24-x-y", please check out #39442 |
trop
bot
added
in-flight/24-x-y
merged/24-x-y
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
fix: update chrome.i18n for Manifest v3
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
fix: update chrome.i18n for Manifest v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updates our implementation of
chrome.i18nto support Promises with Manifest V3. Also adds a fuller test suite forchrome.i18nfunctionality. Note that this does not affect functionality with Manifest V2.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where
chrome.i18ndid not work properly with Chrome Extensions Manifest V3