Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update chrome.tabs for Manifest v3 #39317

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: update chrome.tabs for Manifest v3 #39317

merged 1 commit into from
Aug 3, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Updates our implementation of chrome.tabs to support Promises with Manifest V3. Also adds a fuller test suite for chrome.tabs functionality. Note that this does not affect functionality with Manifest V2.

Checklist

Release Notes

Notes: Notes: Fixes an issue where chrome.tabs did not work properly with Chrome Extensions Manifest V3

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 1, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 1, 2023
@codebytere codebytere force-pushed the fix-tab-return-types branch 2 times, most recently from 5ae7f90 to d40203b Compare August 1, 2023 08:06
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 2, 2023
@codebytere codebytere mentioned this pull request Aug 2, 2023
Merged
5 tasks
jkleinsc
jkleinsc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding tests!

@codebytere codebytere merged commit 6d0e804 into main Aug 3, 2023
17 checks passed
@codebytere codebytere deleted the fix-tab-return-types branch August 3, 2023 16:34
@release-clerk
Copy link

release-clerk bot commented Aug 3, 2023

Release Notes Persisted

Notes: Fixes an issue where chrome.tabs did not work properly with Chrome Extensions Manifest V3

@trop
Copy link
Contributor

trop bot commented Aug 3, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/24-x-y PR should also be added to the "24-x-y" branch. label Aug 3, 2023
@trop trop bot mentioned this pull request Aug 3, 2023
Merged
@trop trop bot mentioned this pull request Aug 3, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Aug 3, 2023

I have automatically backported this PR to "25-x-y", please check out #39359

@trop trop bot added the in-flight/25-x-y label Aug 3, 2023
@trop
Copy link
Contributor

trop bot commented Aug 3, 2023

I have automatically backported this PR to "26-x-y", please check out #39360

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Aug 3, 2023
@trop trop bot added in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/26-x-y labels Aug 3, 2023
This was referenced Aug 7, 2023
Closed
Closed
@electron electron deleted a comment from trop bot Aug 10, 2023
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@codebytere
fix: update chrome.tabs for Manifest v3 (electron#39317)
5a9a728
@commit-lint commit-lint bot mentioned this pull request Oct 12, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: update chrome.tabs for Manifest v3 (electron#39317)
50c4c57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @samuelmaddock