Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dangling raw_ptr in ElectronBrowserMainParts dtor #39539

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: dangling raw_ptr in ElectronBrowserMainParts dtor #39539

merged 2 commits into from
Aug 21, 2023

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Aug 16, 2023 •
edited

Description of Change

Another order-of-destruction issue similar to #39521.

class ElectronBrowserMainParts
{
    ....
    std::unique_ptr<JavascriptEnvironment> js_env_;
    std::unique_ptr<NodeBindings> node_bindings_;
    ....
};

js_env_ holds a pointer to the uv loop owned by node_bindings_, so when node_bindings_ is destroyed before js_env_ in the EBMP destructor, js_env_ is holding onto a dangling pointer when its destructor is called.

CC @deepak1556, @codebytere who reviewed 39521 and @VerteDinde for raw_ptr fun.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Aug 16, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2023
@ckerr ckerr mentioned this pull request Aug 16, 2023
Closed
5 tasks
@ckerr ckerr marked this pull request as draft August 16, 2023 18:37
@ckerr
fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor
f92bab9 
Browser::WhenReady() holds a reference to JsEnv isolate so must come after
@github-actions github-actions bot added the target/27-x-y PR should also be added to the "27-x-y" branch. label Aug 16, 2023
@ckerr ckerr marked this pull request as ready for review August 16, 2023 20:48
VerteDinde
VerteDinde approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2023
@codebytere codebytere merged commit 3a91d1f into main Aug 21, 2023
19 checks passed
@codebytere codebytere deleted the fix/dangling-ptr-in-electron-browser-main-parts-dtor branch August 21, 2023 08:29
@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023

No Release Notes

This was referenced Aug 21, 2023
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "24-x-y", please check out #39591

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Aug 21, 2023
@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "25-x-y", please check out #39592

@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "27-x-y", please check out #39593

@trop
Copy link
Contributor

trop bot commented Aug 21, 2023

I have automatically backported this PR to "26-x-y", please check out #39594

@trop trop bot added in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/24-x-y in-flight/26-x-y in-flight/27-x-y labels Aug 21, 2023
@ckerr ckerr mentioned this pull request Sep 6, 2023
Merged
4 tasks
win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@ckerr
fix: dangling raw_ptr in ElectronBrowserMainParts dtor (electron#39539)
80a6c8a 
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor

* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor

Browser::WhenReady() holds a reference to JsEnv isolate so must come after
@commit-lint commit-lint bot mentioned this pull request Nov 13, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@ckerr
fix: dangling raw_ptr in ElectronBrowserMainParts dtor (electron#39539)
241c547 
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor

* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor

Browser::WhenReady() holds a reference to JsEnv isolate so must come after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ckerr @deepak1556 @codebytere @VerteDinde