Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: non-fullscreenable, non-resizable child windows get fullscreened when being shown if the parent window is fullscreened #39614

Closed
3 tasks done
pushkin- opened this issue Aug 22, 2023 · 4 comments · Fixed by #39620
Assignees
Labels
25-x-y 26-x-y 27-x-y bug 🪲 component/BrowserWindow has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@pushkin-
Copy link

pushkin- commented Aug 22, 2023

Preflight Checklist

Electron Version

26.0.0

What operating system are you using?

macOS

Operating System Version

macOS Ventura 13.2.1

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

I expect that if a child window that's configured to be non-fullscreenable is shown while the parent window is fullscreened, the child window won't get fullscreened.

Actual Behavior

Child window opens fullscreened for some reason and the main window crashes when the child is closed.

Testcase Gist URL

https://gist.github.com/pushkin-/3b4bcdb219eee85789e95f6d94ec8a92

Additional Information

  1. full screen main window
  2. click open window
  3. notice that child window is fullscreened even though it shouldn't be able to get fullscreen
  4. closing the window makes the parent window go black

seems like the invocation of BrowserWindow::show() causes the enter-full-screen event to get emitted for some reason.

Screen.Recording.2023-08-22.at.5.36.43.PM.mov
@pushkin-
Copy link
Author

In my actual app, this also seems to affect resizable windows though I haven't been able to repro in a minimal example yet.

@pushkin-
Copy link
Author

If I unscreen the child window after it opens (Fn+F), and then close it, I don't get a crash. But also why does Fn+F do anything if fullscreenable is set to false. I can use that same hotkey to return it to fullscreen.

@kyle-w-20230331
Copy link

I got the same issue. 😭

@SuperShan0926
Copy link

I got the same issue. 😭

so did I

@codebytere codebytere self-assigned this Aug 23, 2023
@codebytere codebytere added platform/macOS status/confirmed A maintainer reproduced the bug or agreed with the feature component/BrowserWindow has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 25-x-y 26-x-y 27-x-y labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y 26-x-y 27-x-y bug 🪲 component/BrowserWindow has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
No open projects
Status: Unsorted Items
Status: 🛠 Fixed for Next Release
Status: 🛠️ Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

4 participants