ci: use new GitHub App for issue triage related actions #39635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
ci-issue-triage-bot
branch
from
f3b9e7f
to
0c91ecd
Compare
jkleinsc
approved these changes
Aug 30, 2023
|
No Release Notes |
1 task
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The main motivation here is that actions taken by the default
github-actionsbot will not trigger other workflows. This caused some of the automation added in #39464 (which intended to change the status of an issue on the issue triage project when an issue is unlabeled) not to work since the label being removed was done bygithub-actionsso the other workflow was not triggered.For consistency I've changed all issue triage actions to be done by the same GitHub App, which will make it easier to do things like search or checking in other automation, and will let us provide a bit of a more polished UX instead of having it all coming from
github-actions.This PR also updates all token generation from using
npx @electron/github-app-authto using the newelectron/github-app-auth-action.The GitHub App has already been created and
ISSUE_TRIAGE_GH_APP_CREDShas been populated, thanks to @VerteDinde. 馃憤Checklist
Release Notes
Notes: none