docs: Quick Start | Electron Forge chapter requirements updated #39639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note to a pre-require of Electron Forge. Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild`
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
NoxFly
changed the title
erickzhao
suggested changes
Aug 28, 2023
Co-authored-by: Erick Zhao <erick@hotmail.ca>
zcbenz
approved these changes
Aug 31, 2023
zcbenz
changed the title
electron-cation
bot
added
new-pr 🌱
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…tron#39639) * Update quick-start.md Added a note to a pre-require of Electron Forge. Otherwise users will have an error `Cannot make for rpm, the following external binaries need to be installed: rpmbuild` * Add two required steps for Electron Forge to build without errors * Update docs/tutorial/quick-start.md Co-authored-by: Erick Zhao <erick@hotmail.ca> --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added 2 points for the deploiement chapter with Electron Forge.
These 2 points are required, else the rpmbuild will fail.
Checklist
npm testpassesNotes: none