docs: use node: imports for node core modules
#39681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
documentation 📓
semver/patch
dsanders11
approved these changes
Aug 28, 2023
dsanders11
added
target/26-x-y
jkleinsc
approved these changes
Aug 30, 2023
|
Merging as CI failure unrelated to PR change. |
|
No Release Notes |
This was referenced Aug 30, 2023
|
I have automatically backported this PR to "27-x-y", please check out #39694 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "26-x-y", please check out #39695 |
trop
bot
added
in-flight/26-x-y
merged/27-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
docs: use `node:` imports for node builtin modules
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Core Node.js modules (e.g.
os,fs,path) can be imported using thenode:prefixed syntax as of Node.js 16.0/14.18. Node's own documentation has moved to use this prefix syntax for clarity reasons (nodejs/node#42752).After discussing with @electron/docs, we believe we should migrate the syntax in our docs as well to follow suit.
Checklist
npm testpassesRelease Notes
Notes: none