Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't save performance traces from the performance tab in DevTools #39818

Closed
3 tasks done
Mike-Dax opened this issue Sep 12, 2023 · 8 comments
Closed
3 tasks done
Labels
26-x-y bug 🪲 has-repro-comment Issue has repro in comments

Comments

@Mike-Dax
Copy link
Contributor

Mike-Dax commented Sep 12, 2023

Preflight Checklist

Electron Version

26.2.0

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.3 (21E230)

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

24.8.2

Expected Behavior

When recording a performance trace in the devtools, I should be able to hit the save button and save the JSON file for sharing and parsing in other applications.

Actual Behavior

Failed to save timeline: The request is not allowed by the user agent or the platform in the current context. (NotAllowedError) is logged to the console

Zero byte file is created at the save location.

Testcase Gist URL

No response

Additional Information

On macOS Monterey 12.3 (21E230):

24.8.2 works
25.0.0 does not work
25.3.2 does not work
26.2.0 does not work
27.0.0-beta.1 does not work

On a Linux machine, 25.0.0 breaks while 24.0.0 works.

uname -a: Linux 6.5.2-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 06 Sep 2023 21:01:01 +0000 x86_64 GNU/Linux

@Etheryte
Copy link

Etheryte commented Sep 15, 2023

This doesn't seem to be a bug in Electron, but instead an issue in Chromium. I can replicate the same error when trying to record a performance trace on a random webpage using the latest Chrome on macOS for example. I couldn't find a relevant issue on their issue tracker so I went ahead and filed chromium/issues/1483230.

@Mike-Dax
Copy link
Contributor Author

Chrome (Version 117.0.5938.62 (Official Build) (arm64)) works fine for me, while Electron doesn't work.

@Etheryte
Copy link

For context, the issue replicates for me on Chrome versions 116.0.5845.187 (Official Build) (x86_64) as well as 117.0.5938.88 (Official Build) (x86_64). The latter is a slightly newer version than what you are running, so we can rule out them fixing it in Chromium between then and now.

@jkleinsc jkleinsc added has-repro-comment Issue has repro in comments 26-x-y labels Oct 30, 2023
@Bug-Reaper
Copy link

Same issue on:

  • M1-Pro MacOS Ventura 13.5.
  • Electron ^26.2.2

Very unfortunate as this blocks a proper analysis of many consecutive dropped frames w/no execution.

Was unable to resolve by manually applying full-disk access permissions to the bundled electron.app

@scottnonnenberg-signal
Copy link

This reproduces for Electron 27.1.2 in dev mode and in packaged/signed mode, whether saving to paths that are restricted or allowed by the protocol filter.

@devinbinnie
Copy link

This seems to be fixed in Electron v29. Is there any chance it will be fixed in v28 as well? Still reproduces for me on v28.2.3

@pushkin-
Copy link

@devinbinnie based on above, this was a Chromium issue, so not something that Electron fixed. I'd assume a fix won't be backported.

@deepak1556
Copy link
Member

Fixed with #41492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26-x-y bug 🪲 has-repro-comment Issue has repro in comments
Projects
No open projects
Status: 👀 Unsorted Items
Development

No branches or pull requests

8 participants