Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent gin_helper::Locker heap allocation #39847

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: prevent gin_helper::Locker heap allocation #39847

merged 1 commit into from
Sep 14, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 13, 2023

Regressed in #39803

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 13, 2023
@miniak miniak self-assigned this Sep 13, 2023
@miniak miniak requested a review from ckerr September 13, 2023 08:27
@miniak miniak added target/27-x-y PR should also be added to the "27-x-y" branch. semver/none semver/patch backwards-compatible bug fixes and removed semver/none labels Sep 13, 2023
@miniak miniak mentioned this pull request Sep 13, 2023
Merged
3 tasks
@miniak miniak changed the title fix: prevent gin_helper::Locker heap allocation fix: prevent gin_helper::Locker heap allocation Sep 13, 2023
deepak1556
deepak1556 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 14, 2023
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit fb6b920 into main Sep 14, 2023
18 of 19 checks passed
@jkleinsc jkleinsc deleted the miniak/locker-prevent-heap-allocation branch September 14, 2023 19:48
@release-clerk
Copy link

release-clerk bot commented Sep 14, 2023

No Release Notes

@trop trop bot mentioned this pull request Sep 14, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 14, 2023

I have automatically backported this PR to "27-x-y", please check out #39872

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Sep 14, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
fix: prevent gin_helper::Locker heap allocation (electron#39847)
b9bb44d 
fix: prevent gin_helper::Locker heap allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees

@miniak miniak

Labels
merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @jkleinsc @deepak1556 @codebytere