Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing include for std::variant #40007

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore: add missing include for std::variant #40007

merged 1 commit into from
Sep 28, 2023

Conversation

brjsp
Copy link
Contributor

@brjsp brjsp commented Sep 27, 2023

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 27, 2023
ckerr
ckerr approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2023
@jkleinsc jkleinsc merged commit dd7395e into electron:main Sep 28, 2023
17 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2023

No Release Notes

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@brjsp
chore: add missing include for std::variant (electron#40007)
01d475e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brjsp @ckerr @RaisinTen @jkleinsc