Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: desktopCapturer source IDs are valid for a single use on Wayland #40097

Closed
3 tasks done
aiddya opened this issue Oct 5, 2023 · 1 comment · Fixed by #40098
Closed
3 tasks done

[Bug]: desktopCapturer source IDs are valid for a single use on Wayland #40097

aiddya opened this issue Oct 5, 2023 · 1 comment · Fixed by #40098
Labels
27-x-y bug 🪲 component/desktopcapturer has-repro-gist Issue can be reproduced with code at https://gist.github.com/ wayland

Comments

@aiddya
Copy link
Contributor

aiddya commented Oct 5, 2023

Preflight Checklist

Electron Version

27.0.0-beta.9

What operating system are you using?

Other Linux

Operating System Version

Fedora Workstation 39

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

  1. Get a source ID from desktopCapturer
  2. Display the stream using getUserMedia
  3. Stop the stream
  4. Display the stream again using getUserMedia

Actual Behavior

XDG desktop portal permission dialog appears again

Testcase Gist URL

https://gist.github.com/aiddya/cfd89d040661e0553425e4203ce4512b

Additional Information

The fiddle has a timeout function that displays the stream after 10 seconds. So the steps to test using the fiddle boil down to: select a source, preview it, stop it and then wait 10 seconds.
@aiddya aiddya added the bug 🪲 label Oct 5, 2023
@aiddya aiddya mentioned this issue Oct 5, 2023
Merged
3 tasks
@codebytere codebytere added component/desktopcapturer wayland 27-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ labels Oct 5, 2023
@ProdigyView
Copy link

I am actually have the same issue on windows on version v26.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
27-x-y bug 🪲 component/desktopcapturer has-repro-gist Issue can be reproduced with code at https://gist.github.com/ wayland
Projects
No open projects
27-x-y
Status: 🛠️ Fixed for Next Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: store portal restore token under the right source ID aiddya/electron
3 participants
@ProdigyView @codebytere @aiddya