-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix vibrancy applying without transparency on MacOS #40109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
target/27-x-y
PR should also be added to the "27-x-y" branch.
semver/patch
backwards-compatible bug fixes
labels
Oct 5, 2023
VerteDinde
force-pushed
the
fix-transparency-mac
branch
from
October 5, 2023 20:16
f79a7d6
to
4fdf160
Compare
VerteDinde
force-pushed
the
fix-transparency-mac
branch
from
October 5, 2023 21:13
4fdf160
to
f8dfc19
Compare
VerteDinde
changed the title
fix: fix vibrancy applying without transparency
fix: fix vibrancy applying without transparency on MacOS
Oct 5, 2023
zcbenz
approved these changes
Oct 5, 2023
Co-authored-by: samuelmaddock <samuelmaddock@electronjs.org>
samuelmaddock
approved these changes
Oct 6, 2023
clavin
approved these changes
Oct 6, 2023
Release Notes Persisted
|
I have automatically backported this PR to "27-x-y", please check out #40130 |
trop
bot
added
in-flight/27-x-y
merged/27-x-y
PR was merged to the "27-x-y" branch.
and removed
target/27-x-y
PR should also be added to the "27-x-y" branch.
in-flight/27-x-y
labels
Oct 6, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged/27-x-y
PR was merged to the "27-x-y" branch.
new-pr 🌱
PR opened in the last 24 hours
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A follow-up to #39708 - this PR fixes applying transparency as a background color when vibrancy is also set.
Closes #40039
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue with applying vibrancy on non-transparent windows on MacOS.