Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated crashed and renderer-process-crashed events #40115

Merged
merged 1 commit into from Oct 18, 2023
Merged

chore: remove deprecated crashed and renderer-process-crashed events #40115

merged 1 commit into from Oct 18, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 6, 2023 •
edited

Description of Change

Follow-up to #40089

Checklist

Release Notes

Notes: The deprecated renderer-process-crashed event on app and crashed event on WebContents and <webview> have been removed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 6, 2023
@miniak miniak self-assigned this Oct 6, 2023
@miniak miniak added semver/major incompatible API changes no-backport labels Oct 6, 2023
@miniak miniak force-pushed the miniak/remove-renderer-process-crashed branch from 846ac3d to d28ee80 Compare October 6, 2023 08:51
@miniak miniak changed the title chore: remove deprecated crashed and render-process-gone events chore: remove deprecated crashed and renderer-process-crashed events Oct 6, 2023
@miniak miniak force-pushed the miniak/remove-renderer-process-crashed branch 2 times, most recently from 2492c01 to 1c55e40 Compare October 10, 2023 21:53
@miniak miniak force-pushed the miniak/remove-renderer-process-crashed branch from 1c55e40 to 954b4f9 Compare October 11, 2023 00:03
@electron-cation
Copy link

electron-cation bot commented Oct 11, 2023 •
edited by miniak

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 🏷️ Pull request is labeled as semver/major incompatible API changes
  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

@miniak miniak marked this pull request as ready for review October 11, 2023 21:56
@miniak miniak requested a review from a team as a code owner October 11, 2023 21:56
zcbenz
zcbenz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

codebytere
codebytere approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit 657e88b into main Oct 18, 2023
17 of 18 checks passed
@codebytere codebytere deleted the miniak/remove-renderer-process-crashed branch October 18, 2023 10:05
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

Release Notes Persisted

The deprecated renderer-process-crashed event on app and crashed event on WebContents and &lt;webview&gt; have been removed.

trop bot added a commit that referenced this pull request Oct 18, 2023
@trop @miniak
chore: remove deprecated crashed and renderer-process-crashed eve…
aa36cff 
…nts (#40115)

Co-authored-by: Milan Burda <milan.burda@gmail.com>
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
@miniak @felixrieseberg
chore: remove deprecated crashed and renderer-process-crashed eve…
fb109ba 
…nts (electron#40115)
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: remove deprecated crashed and renderer-process-crashed eve…
f73ec23 
…nts (electron#40115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
api-review/requested 🗳 deprecation-review/complete ✅ new-pr 🌱 PR opened in the last 24 hours no-backport semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @codebytere