Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fixup diagnose_goma_log.py call #40131

Merged
merged 1 commit into from
Oct 9, 2023
Merged

ci: fixup diagnose_goma_log.py call #40131

merged 1 commit into from
Oct 9, 2023

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Oct 6, 2023

Description of Change

The call to diagnose_goma_log.py after builds was failing with the error:

 File "/home/builduser/project/build-tools/third_party/goma/diagnose_goma_log.py", line 184
    yield from f
             ^
SyntaxError: invalid syntax

eg see https://app.circleci.com/pipelines/github/electron/electron/75261/workflows/0ea342e8-4faa-43bc-a706-9f59312f2c10/jobs/1616734/parallel-runs/0/steps/0-127.

This PR explictly runs that utility with python3 which fixes the issue.

Checklist

Release Notes

Notes: none

dsanders11
dsanders11 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shebang for goma_ctl.py already specifies python3, but doesn't hurt to explicitly specify it. The shebang for diagnose_goma_log.py should be updated upstream since it requires python3 now.

@codebytere codebytere added target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 9, 2023
@codebytere codebytere merged commit a31deea into main Oct 9, 2023
22 checks passed
@codebytere codebytere deleted the fixup-goma-diag branch October 9, 2023 13:19
@release-clerk
Copy link

release-clerk bot commented Oct 9, 2023

No Release Notes

This was referenced Oct 9, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 9, 2023

I have automatically backported this PR to "27-x-y", please check out #40149

@trop trop bot added the in-flight/27-x-y label Oct 9, 2023
@trop trop bot mentioned this pull request Oct 9, 2023
Merged
@trop trop bot removed the target/27-x-y PR should also be added to the "27-x-y" branch. label Oct 9, 2023
@trop
Copy link
Contributor

trop bot commented Oct 9, 2023

I have automatically backported this PR to "25-x-y", please check out #40150

@trop
Copy link
Contributor

trop bot commented Oct 9, 2023

I have automatically backported this PR to "26-x-y", please check out #40151

@trop trop bot added in-flight/25-x-y in-flight/26-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/27-x-y in-flight/25-x-y in-flight/26-x-y labels Oct 9, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@jkleinsc
ci: fixup diagnose_goma_log.py call (electron#40131)
989ac32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @codebytere @dsanders11