Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename renderer.d.ts in documentation #40137

Merged
merged 1 commit into from Oct 13, 2023

Conversation

maxtower
Copy link
Contributor

@maxtower maxtower commented Oct 7, 2023

Description of Change

renderer.d.ts doesn't compile when the declaration name has the same root name as the TS file.

microsoft/TypeScript#7624 (comment)

https://stackoverflow.com/questions/59728371/typescript-d-ts-file-not-recognized

Checklist

  • relevant documentation, tutorials, templates and examples are changed or added

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Oct 7, 2023

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 7, 2023
@maxtower maxtower changed the title Rename renderer.d.ts in documentation docs: Rename renderer.d.ts in documentation Oct 7, 2023
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 7, 2023
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - good catch!

@codebytere codebytere changed the title docs: Rename renderer.d.ts in documentation docs: rename renderer.d.ts in documentation Oct 9, 2023
@codebytere codebytere merged commit dc4476d into electron:main Oct 13, 2023
21 checks passed
@welcome
Copy link

welcome bot commented Oct 13, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Oct 13, 2023

No Release Notes

felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants