Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make capturePage color matching timeouts consistent #40158

Merged
merged 1 commit into from
Oct 10, 2023
Merged

test: make capturePage color matching timeouts consistent #40158

merged 1 commit into from
Oct 10, 2023

Conversation

codebytere
Copy link
Member

Description of Change

It used to be the case that BrowserWindow "transparent" option should not display a visible background flaked much more frequently before we added a 1000ms timeout. We have timeouts in similar test that still flake (see here) - I think we should make these consistent as we've seen that 1000ms is more reliably enough time to prevent snapshot races.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/none target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 10, 2023
jkleinsc
jkleinsc reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed these tests flaking. Thanks for addressing!

@jkleinsc jkleinsc merged commit 7e312c8 into main Oct 10, 2023
22 checks passed
@jkleinsc jkleinsc deleted the consistent-timeouts branch October 10, 2023 15:13
@release-clerk
Copy link

release-clerk bot commented Oct 10, 2023

No Release Notes

@trop trop bot mentioned this pull request Oct 10, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 10, 2023

I have automatically backported this PR to "25-x-y", please check out #40165

@trop trop bot mentioned this pull request Oct 10, 2023
Merged
@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Oct 10, 2023
@trop trop bot mentioned this pull request Oct 10, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 10, 2023

I have automatically backported this PR to "27-x-y", please check out #40166

@trop
Copy link
Contributor

trop bot commented Oct 10, 2023

I have automatically backported this PR to "26-x-y", please check out #40167

@trop trop bot added in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y in-flight/27-x-y labels Oct 10, 2023
@trop trop bot removed the in-flight/26-x-y label Oct 10, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
test: make capturePage color matching timeouts consistent (electron#4…
1594b85 
…0158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak Awaiting requested review from miniak

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc