Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: formally deprecate gpu-process-crashed event #40169

Merged
merged 1 commit into from Oct 12, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 10, 2023

Description of Change

Follow-up to #40089. Deprecated by #24367.

Checklist

Release Notes

Notes: The gpu-process-crashed event on app has been deprecated.

@miniak miniak requested a review from a team as a code owner October 10, 2023 23:55
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 10, 2023
@miniak miniak self-assigned this Oct 10, 2023
@electron-cation
Copy link

electron-cation bot commented Oct 10, 2023

🪦 Deprecation Checklist

🔥 New deprecations in this PR

  • 📢 Are called out in docs/breaking-changes.md
  • ⚠️ Use the deprecation helpers in lib/common/deprecate.ts to warn about usage (including events)
  • 📝 Are marked as deprecated in the docs, using _Deprecated_ (including properties and events)

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

@miniak
Copy link
Contributor Author

miniak commented Oct 11, 2023

@dsanders11 the gpu-process-crashed is kind of tricky to test, are you ok if I skip that?

@miniak miniak added target/28-x-y PR should also be added to the "28-x-y" branch. and removed no-backport labels Oct 11, 2023
@dsanders11
Copy link
Member

@miniak, that's reasonable. I wonder if we should tweak our deprecation helper for events to warn when you bind an event listener, rather than when the event fires.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 11, 2023
@jkleinsc jkleinsc merged commit 344f8fd into main Oct 12, 2023
24 checks passed
@jkleinsc jkleinsc deleted the miniak/deprecate-gpu-process-crashed branch October 12, 2023 18:53
@release-clerk
Copy link

release-clerk bot commented Oct 12, 2023

Release Notes Persisted

The gpu-process-crashed event on app has been deprecated.

@trop
Copy link
Contributor

trop bot commented Oct 12, 2023

I have automatically backported this PR to "28-x-y", please check out #40195

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 12, 2023
@miniak
Copy link
Contributor Author

miniak commented Oct 13, 2023

@miniak, that's reasonable. I wonder if we should tweak our deprecation helper for events to warn when you bind an event listener, rather than when the event fires.

@dsanders11 that's a good idea

@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/28-x-y labels Oct 16, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🗑 Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants