fix: incorrect wco bounds in macOS fullscreen #40179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
electron-cation
bot
added
new-pr 🌱
zcbenz
approved these changes
Oct 16, 2023
|
Release Notes Persisted
|
This was referenced Oct 16, 2023
|
I have automatically backported this PR to "27-x-y", please check out #40217 |
trop
bot
added
in-flight/27-x-y
and removed
target/27-x-y
|
I have automatically backported this PR to "26-x-y", please check out #40218 |
|
I have automatically backported this PR to "28-x-y", please check out #40219 |
|
I have automatically backported this PR to "25-x-y", please check out #40220 |
trop
bot
added
in-flight/28-x-y
in-flight/25-x-y
and removed
target/26-x-y
trop
bot
added
merged/27-x-y
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39885.
Fixes an issue where webContents elements in the traffic light area couldn't be interacted with if a BrowserWindow with
titleBarOverlayenabled was fullscreen. This was happeningBrowserWindowentered or exited fullscreen that it should update WCO{ 0, 0 }intentionally while the overlay was active.This addresses that by making the return value of
GetWindowControlsOverlayRectoptional to distinguish intent. See here for similar handling upstream.Tested with https://gist.github.com/sergeichestakov/c84835f4d80182744b99e837268edc7c
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue with webContents interaction with fullscreen and WCO on macOS.