fix: Windows Toast notification dismissal from Action Center #40197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-notifications-remove-after-close
branch
2 times, most recently
from
ae8c5a3
to
f013c0d
Compare
zcbenz
reviewed
Oct 17, 2023
codebytere
force-pushed
the
fix-notifications-remove-after-close
branch
from
c18de9b
to
6a637fa
Compare
zcbenz
approved these changes
Oct 17, 2023
jkleinsc
approved these changes
Oct 17, 2023
|
Merging as CI failure is unrelated to PR changed and is fixed via #40241. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "26-x-y", please check out #40242 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "28-x-y", please check out #40243 |
|
I have automatically backported this PR to "27-x-y", please check out #40244 |
trop
bot
added
in-flight/28-x-y
in-flight/27-x-y
merged/27-x-y
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
…n#40197) * fix: Windows Toast notification dismissal from Action Center * docs: note Toast behavior in event * chore: address feedback from review
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…n#40197) * fix: Windows Toast notification dismissal from Action Center * docs: note Toast behavior in event * chore: address feedback from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #40133
Inspiration taken from upstream
This PR closes a longstanding issue whereby Windows Toast notifications could only be dismissed and prevented from living in the Action Center until removed by the user if
.closeis called on them while the Notification is visible to the user. On an API level, WhenToastNotifier.Hideis called, theToastNotificationis removed from the screen if it is currently visible, and it is not sent to the Action Center. AToastNotificationis considered dismissed per underlying callbacks if it leaves the screen, and so our existing logic destroyed and garbage collected the underlying notification as soon as the notification left the screen regardless of whether it was dismissed programmatically, by the user, or by timeout.If it was dismissed by the user or by timeout, it entered the Action Center, and
notification.close()then appeared to have no effect because the notification in JS-land was still alive. In order to address this problem, and ensure that the notification's behavior aligned more closely with 1) our documentation and 2) other platforms, we need to make some changes to garbage collection behavior as well as which APIs are called depending on whether theToastNotificationhas already entered the Action Center. If it is dismissed by timeout or sent to the Action Center by the user, we want to notify the user via event, but now, we do not want to immediately destroy the underlying notification. We instead want to wait until the notification is destroyed programmatically or removed from the action center to destroy the underlyingToastNotification. We use theToastNotificationHistoryclass to remove it from the Action Center.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Windows Toast notifications weren't properly dismissed from the Action Center on
notification.close()if they'd previously been dismissed.