New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement no-op chrome.action
extension APIs
#40222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
backwards-compatible bug fixes
target/26-x-y
PR should also be added to the "26-x-y" branch.
target/27-x-y
PR should also be added to the "27-x-y" branch.
target/28-x-y
PR should also be added to the "28-x-y" branch.
labels
Oct 16, 2023
codebytere
force-pushed
the
chrome-action
branch
from
October 16, 2023 13:07
e4224ce
to
8c9759d
Compare
codebytere
force-pushed
the
chrome-action
branch
from
October 16, 2023 15:11
8c9759d
to
c8a92c0
Compare
jkleinsc
approved these changes
Oct 17, 2023
No Release Notes |
This was referenced Oct 18, 2023
I have automatically backported this PR to "26-x-y", please check out #40259 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
PR should also be added to the "26-x-y" branch.
labels
Oct 18, 2023
I have automatically backported this PR to "27-x-y", please check out #40260 |
I have automatically backported this PR to "28-x-y", please check out #40261 |
trop
bot
added
in-flight/27-x-y
in-flight/28-x-y
merged/28-x-y
PR was merged to the "28-x-y" branch.
and removed
target/27-x-y
PR should also be added to the "27-x-y" branch.
target/28-x-y
PR should also be added to the "28-x-y" branch.
in-flight/28-x-y
labels
Oct 18, 2023
trop
bot
added
merged/27-x-y
PR was merged to the "27-x-y" branch.
merged/26-x-y
PR was merged to the "26-x-y" branch.
and removed
in-flight/27-x-y
in-flight/26-x-y
labels
Oct 18, 2023
In which Electron version this change will be available for testing? |
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
chore: implement no-op chrome.action extension APIs
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
chore: implement no-op chrome.action extension APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged/26-x-y
PR was merged to the "26-x-y" branch.
merged/27-x-y
PR was merged to the "27-x-y" branch.
merged/28-x-y
PR was merged to the "28-x-y" branch.
semver/patch
backwards-compatible bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #36545.
Refs #40142.
Implement scaffolding for unsupported
chrome.action
API surface. From documentation:Electron has no comparable concept for the toolbar button or popup, and will never support this API. However, as of now, many extensions use it, and it throws disruptive errors that can prevent other supported aspects of a given extension from working as intended. To combat this, I'm adding stripped-down infrastructure for the API without supporting it, such that it will not throw an error when
chrome.action
APIs are called but will log that the APIs are unsupported and will not work as expected. This will prevent confusing errors for users and more clearly delineate what we do and don't support.This approach was also taken in this PR.
Checklist
npm test
passesRelease Notes
Notes: none.