Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement no-op chrome.action extension APIs #40222

Merged
merged 1 commit into from Oct 18, 2023
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Oct 16, 2023

Description of Change

Refs #36545.
Refs #40142.

Implement scaffolding for unsupported chrome.action API surface. From documentation:

You can use the chrome.action API to control the toolbar button for your extension in Chrome's UI. The action icons are displayed in the browser toolbar, to the right of the omnibox (on left-to-right devices). After installation, by default, these appear in the extensions menu (the puzzle piece). Users can choose to pin your extension icon to the toolbar.

Electron has no comparable concept for the toolbar button or popup, and will never support this API. However, as of now, many extensions use it, and it throws disruptive errors that can prevent other supported aspects of a given extension from working as intended. To combat this, I'm adding stripped-down infrastructure for the API without supporting it, such that it will not throw an error when chrome.action APIs are called but will log that the APIs are unsupported and will not work as expected. This will prevent confusing errors for users and more clearly delineate what we do and don't support.

This approach was also taken in this PR.

Checklist

Release Notes

Notes: none.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 16, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 16, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 17, 2023
@jkleinsc jkleinsc merged commit 5b105f9 into main Oct 18, 2023
17 checks passed
@jkleinsc jkleinsc deleted the chrome-action branch October 18, 2023 14:19
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 18, 2023

I have automatically backported this PR to "26-x-y", please check out #40259

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Oct 18, 2023
@trop
Copy link
Contributor

trop bot commented Oct 18, 2023

I have automatically backported this PR to "27-x-y", please check out #40260

@trop
Copy link
Contributor

trop bot commented Oct 18, 2023

I have automatically backported this PR to "28-x-y", please check out #40261

@trop trop bot added in-flight/27-x-y in-flight/28-x-y merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/28-x-y labels Oct 18, 2023
@trop trop bot added merged/27-x-y PR was merged to the "27-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/27-x-y in-flight/26-x-y labels Oct 18, 2023
@patil-milind
Copy link

In which Electron version this change will be available for testing?

felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
chore: implement no-op chrome.action extension APIs
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
chore: implement no-op chrome.action extension APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants