Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix represented file fiddle #40233

Merged
merged 1 commit into from Oct 18, 2023
Merged

Conversation

dsanders11
Copy link
Member

Description of Change

Fixes #38406

Also tweaks it to match our latest best practices.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation, tutorials, templates and examples are changed or added

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Oct 17, 2023
@dsanders11 dsanders11 added target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 17, 2023
@dsanders11 dsanders11 marked this pull request as draft October 17, 2023 22:58
@dsanders11 dsanders11 marked this pull request as ready for review October 17, 2023 23:53
@codebytere codebytere merged commit 09bab60 into main Oct 18, 2023
21 checks passed
@codebytere codebytere deleted the docs-represented-file-fiddle branch October 18, 2023 09:32
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 18, 2023

I have automatically backported this PR to "27-x-y", please check out #40251

@trop trop bot added in-flight/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 18, 2023
@trop
Copy link
Contributor

trop bot commented Oct 18, 2023

I have automatically backported this PR to "28-x-y", please check out #40252

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 18, 2023
trop bot added a commit that referenced this pull request Oct 18, 2023
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/28-x-y in-flight/27-x-y labels Oct 19, 2023
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the example in the document of represented file creates BrowserWindow twice
2 participants