Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixup node force colors test #40241

Merged
merged 2 commits into from Oct 18, 2023
Merged

test: fixup node force colors test #40241

merged 2 commits into from Oct 18, 2023

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Oct 17, 2023 •
edited

Description of Change

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/none no-backport labels Oct 17, 2023
@jkleinsc jkleinsc requested a review from a team as a code owner October 17, 2023 23:21
@jkleinsc jkleinsc mentioned this pull request Oct 17, 2023
Merged
4 tasks
@codebytere codebytere mentioned this pull request Oct 18, 2023
Merged
@codebytere codebytere merged commit 29270f3 into main Oct 18, 2023
13 of 14 checks passed
@codebytere codebytere deleted the fixup-color-test-again branch October 18, 2023 10:33
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

No Release Notes

trop bot added a commit that referenced this pull request Oct 18, 2023
@trop @jkleinsc
test: fixup node force colors test (#40241)
cde5eaf 
* test: fixup node force colors test

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
@jkleinsc @patchup @felixrieseberg
test: fixup node force colors test (electron#40241)
40fdfa1 
* test: fixup node force colors test

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@jkleinsc @patchup
test: fixup node force colors test (electron#40241)
364fd30 
* test: fixup node force colors test

* chore: update patches

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere