Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add spec for child-process-gone event for utility process #40281

Merged
merged 1 commit into from Oct 23, 2023
Merged

test: add spec for child-process-gone event for utility process #40281

merged 1 commit into from Oct 23, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 19, 2023 •
edited

Notes: none

@miniak miniak added target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 19, 2023
@miniak miniak self-assigned this Oct 19, 2023
@miniak miniak force-pushed the miniak/child-process-gone-spec branch from 781a1de to 867fe6f Compare October 20, 2023 00:05
AbdullahWins
AbdullahWins reviewed Oct 21, 2023
View reviewed changes
Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

@jkleinsc jkleinsc merged commit a867503 into main Oct 23, 2023
18 checks passed
@jkleinsc jkleinsc deleted the miniak/child-process-gone-spec branch October 23, 2023 15:30
@release-clerk
Copy link

release-clerk bot commented Oct 23, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/25-x-y PR should also be added to the "25-x-y" branch. label Oct 23, 2023
@trop trop bot mentioned this pull request Oct 23, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/25-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Oct 23, 2023
@trop trop bot mentioned this pull request Oct 23, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

I have automatically backported this PR to "28-x-y", please check out #40304

@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

I have automatically backported this PR to "27-x-y", please check out #40305

@trop trop bot added in-flight/27-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 23, 2023
@miniak miniak mentioned this pull request Oct 23, 2023
Merged
@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/28-x-y labels Oct 23, 2023
miniak added a commit that referenced this pull request Oct 23, 2023
@miniak
test: add spec for child-process-gone event for utility process (#4…
b24c483 
…0281)
miniak added a commit that referenced this pull request Oct 23, 2023
@miniak
test: add spec for child-process-gone event for utility process (#4…
214a269 
…0281)
@miniak miniak mentioned this pull request Oct 23, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

@miniak has manually backported this PR to "26-x-y", please check out #40309

@miniak miniak mentioned this pull request Oct 23, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 23, 2023

@miniak has manually backported this PR to "25-x-y", please check out #40310

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed needs-manual-bp/25-x-y in-flight/25-x-y in-flight/26-x-y labels Oct 23, 2023
codebytere pushed a commit that referenced this pull request Oct 24, 2023
@miniak
test: add spec for child-process-gone event for utility process (#4…
b77eb9c 
…0309)

test: add spec for `child-process-gone` event for utility process (#40281)
codebytere pushed a commit that referenced this pull request Oct 24, 2023
@miniak
test: add spec for child-process-gone event for utility process (#4…
fc98a28 
…0310)

test: add spec for `child-process-gone` event for utility process (#40281)
@trop trop bot added merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/27-x-y labels Oct 24, 2023
@miniak miniak mentioned this pull request Oct 24, 2023
Merged
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
@miniak @felixrieseberg
test: add spec for child-process-gone event for utility process (el…
9825a31 
…ectron#40281)
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
test: add spec for child-process-gone event for utility process (el…
dec38c2 
…ectron#40281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdullahWins AbdullahWins AbdullahWins left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees

@miniak miniak

Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @jkleinsc @deepak1556 @dsanders11 @AbdullahWins