fix: make sure classes in lib correctly implement Electron interfaces #40291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
commented
Oct 20, 2023
| @@ -15,7 +15,7 @@ class AutoUpdater extends EventEmitter { | |||
| } | |||
|
|
|||
| getFeedURL () { | |||
| return this.updateURL; | |||
| return this.updateURL ?? ''; | |||
There was a problem hiding this comment.
the Mac implementation returns an empty string here if the URL is not specified. We should either do that here as well, or change the documentation to allow null
miniak
force-pushed
the
miniak/class-implements
branch
from
574752f
to
a506004
Compare
miniak
force-pushed
the
miniak/class-implements
branch
from
a506004
to
e616e02
Compare
ckerr
approved these changes
Oct 24, 2023
they are green now |
|
No Release Notes |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already doing it in some places such as
electron/lib/browser/api/net-client-request.ts
Line 299 in beb0cbc
Let's do it consistently everywhere
Notes: none