fix: navigator.keyboard.lock() fullscreen exit handling
#40365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-keyboard-lock-fullscreen-handling
branch
3 times, most recently
from
dd045dd
to
391946a
Compare
codebytere
force-pushed
the
fix-keyboard-lock-fullscreen-handling
branch
from
391946a
to
ceae6fd
Compare
jkleinsc
approved these changes
Oct 31, 2023
|
Release Notes Persisted
|
This was referenced Oct 31, 2023
|
I have automatically backported this PR to "26-x-y", please check out #40387 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #40388 |
|
I have automatically backported this PR to "28-x-y", please check out #40389 |
trop
bot
added
in-flight/27-x-y
in-flight/28-x-y
and removed
target/27-x-y
trop
bot
added
merged/26-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…0365) fix: navigator.keyboard.lock() fullscreen exit handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #40342.
Fixes an issue where
navigator.keyboard.lock()did not work per latest expected behavior - pressing Esc exited fullscreen immediately despite a keyboard lock being present to capture the key. We added this behavior historically when we didn't use theExclusiveAccessManager- it now handles fullscreen capture and exit when necessary.This can be tested with https://fullscreen-keyboard-lock.glitch.me - now, pressing and holding escape correctly triggers
RequiresPressAndHoldEscToExit()and associated logic.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where
navigator.keyboard.lock()did not work per latest expected behavior