Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keyboard.lock() should use permissions helper #40460

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: keyboard.lock() should use permissions helper #40460

merged 1 commit into from
Nov 9, 2023

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 6, 2023

Backport of #40369

See that PR for details.

Notes: Added keyboardLock to ses.setPermissionRequestHandler(handler).

@trop @codebytere
feat: keyboard.lock should use permissions helper
6809e4d 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from codebytere November 6, 2023 19:55
@trop trop bot mentioned this pull request Nov 6, 2023
Merged
4 tasks
@trop trop bot added 28-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Nov 6, 2023
codebytere
codebytere approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on November 8th, 2023.

@codebytere codebytere merged commit 460b8dc into 28-x-y Nov 9, 2023
18 checks passed
@codebytere codebytere deleted the trop/28-x-y-bp-feat-keyboard-lock-should-use-permissions-helper-1699300486200 branch November 9, 2023 18:41
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 9, 2023

Release Notes Persisted

Added keyboardLock to ses.setPermissionRequestHandler(handler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
28-x-y backport/approved ✅ backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @georgexu99