New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump node to v18.18.2 #40472
Merged
Merged
chore: bump node to v18.18.2 #40472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trop
bot
added
28-x-y
backport
This is a backport PR
semver/patch
backwards-compatible bug fixes
labels
Nov 7, 2023
baparham
force-pushed
the
bump-node-18.18.2
branch
from
November 7, 2023 13:47
1475ea7
to
68505a0
Compare
oh, shoot, I probably also need to incorporate the changes from #40174 don't I? That may explain why the circle CI builds are failing to apply the patches 🤦 |
* chore: bump node in DEPS to v18.18.1 * Revert "deps: upgrade to libuv 1.46.0" nodejs/node#50036 * chore: fixup patch indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: bump node in DEPS to v18.18.2 * chore: update patches * deps: update nghttp2 to 1.55.0 nodejs/node#48746 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
baparham
force-pushed
the
bump-node-18.18.2
branch
from
November 7, 2023 13:59
68505a0
to
4968d81
Compare
codebytere
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updating Node.js to 18.18.2 to roll to latest security patches from Node.js' Oct 13th security release
See all changes in v18.18.0..18.18.2
Cherry picked from main 7ab2a82 and 6d0d350
Backport of #40174
Backport of #40205
cc: @codebytere @ckerr @jkleinsc
Checklist
Release Notes
Notes: Updated Node.js to latest security release v18.18.2