New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable code cache for custom protocols #40544
Conversation
Should we enforce a good default be only allowing code cache for standard custom schemes, since the cache key relies on origin lock of the process when available. Custom protocols with null origin will have their code cache grouped together and I am not sure cache will be useful in that case since there is more chance of collision. |
b556fc1
to
976689f
Compare
I updated the API to throw when trying to enabling code cache for non-standard scheme. |
132f235
to
2aad9dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
1453c59
to
035726d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API LGTM
Release Notes Persisted
|
I have automatically backported this PR to "27-x-y", please check out #40708 |
I have automatically backported this PR to "28-x-y", please check out #40709 |
Description of Change
Add an option in
protocol.registerSchemesAsPrivileged
to allow V8 code cache in custom schemes.Upstream Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1500437.
/cc @deepak1556 and @bpasero since there will need changes in VS Code.
Fixes #27075
Checklist
npm test
passesRelease Notes
Notes: Add an option in
protocol.registerSchemesAsPrivileged
to allow V8 code cache in custom schemes.