chore: allow passing more roots to lint.js #40571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zcbenz
force-pushed
the
extend-lint-js
branch
from
57575c0
to
122d3a4
Compare
deepak1556
approved these changes
Nov 21, 2023
VerteDinde
approved these changes
Nov 21, 2023
|
No Release Notes |
|
/trop run backport-to 28-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "28-x-y" cleanly; |
miniak
pushed a commit
that referenced
this pull request
Nov 28, 2023
miniak
pushed a commit
that referenced
this pull request
Nov 28, 2023
zcbenz
added a commit
that referenced
this pull request
Nov 28, 2023
zcbenz
added a commit
that referenced
this pull request
Nov 29, 2023
chore: allow passing more roots to lint.js (#40571) Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
dsanders11
pushed a commit
to dsanders11/electron
that referenced
this pull request
Nov 29, 2023
chore: allow passing more roots to lint.js (electron#40571) Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Vendor builds have their own patches and extensions on Electron, this PR makes it possible for vendor builds to lint their code reusing Electron's lint scripts, with args like
lint.js --javascript --javascript--roots=../vendor.Checklist
npm testpassesRelease Notes
Notes: none