Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not call after() async_hook for asyncId 0 #40574

Merged
merged 1 commit into from Nov 22, 2023
Merged

fix: do not call after() async_hook for asyncId 0 #40574

merged 1 commit into from Nov 22, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Refs nodejs/node#41424

We need to keep our handling in ErrorMessageListener in sync with that in Node.js' createOnGlobalUncaughtException().

Fixing incidental to #40573, but that is unfortunately a separate issue.

Checklist

Release Notes

Notes: Fix a potential issue with async_hook corruption in some error contexts.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Nov 21, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 21, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 22, 2023
@codebytere codebytere merged commit e78ce82 into main Nov 22, 2023
23 checks passed
@codebytere codebytere deleted the update-async-hook-handling branch November 22, 2023 16:37
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 22, 2023

Release Notes Persisted

Fix a potential issue with async_hook corruption in some error contexts.

This was referenced Nov 22, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2023

I have automatically backported this PR to "26-x-y", please check out #40592

@trop trop bot added in-flight/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. labels Nov 22, 2023
@trop
Copy link
Contributor

trop bot commented Nov 22, 2023

I have automatically backported this PR to "27-x-y", please check out #40593

@trop
Copy link
Contributor

trop bot commented Nov 22, 2023

I have automatically backported this PR to "28-x-y", please check out #40594

@trop trop bot added in-flight/27-x-y in-flight/28-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/27-x-y labels Nov 22, 2023
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/28-x-y in-flight/26-x-y labels Nov 23, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
fix: do not call after() async_hook for asyncId 0 (electron#40574)
19fcdab 
fix: do not call after() async_hook for asyncId 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @deepak1556