chore: make use of the v8_expose_public_symbols flag #40624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
v8-expose-public-symbols
branch
from
31e5951
to
7bd55cc
Compare
codebytere
approved these changes
Nov 28, 2023
Use the newly added v8_expose_public_symbols flag to expose V8 symbols, instead of relying on custom patches.
zcbenz
force-pushed
the
v8-expose-public-symbols
branch
from
7bd55cc
to
78c09a3
Compare
|
No Release Notes |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* chore: make use of the v8_expose_public_symbols flag Use the newly added v8_expose_public_symbols flag to expose V8 symbols, instead of relying on custom patches. * chore: update patches --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use the newly added
v8_expose_public_symbolsflag to expose V8 symbols, instead of relying on custom patches.Upstream changes:
https://chromium-review.googlesource.com/c/v8/v8/+/5052302
https://chromium-review.googlesource.com/c/v8/v8/+/5052522
Release Notes
Notes: none