chore: cleanup global reject handler leaking into tests #40689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Dec 4, 2023
|
No Release Notes |
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
jkleinsc
pushed a commit
that referenced
this pull request
Jan 22, 2024
(cherry picked from commit 3a510a2)
jkleinsc
added a commit
that referenced
this pull request
Jan 22, 2024
* chore: bump chromium in DEPS to 120.0.6099.217 * chore: bump chromium in DEPS to 120.0.6099.224 * chore: update patches * chore: update patches * chore: bump chromium in DEPS to 120.0.6099.226 * chore: fixup patches after rebase * test: fixup assertNotWindows (#41045) * chore: fixup assertNotWindows * remove logging (cherry picked from commit 3dafb31) * chore: bump chromium in DEPS to 120.0.6099.225 * chore: cleanup global reject handler leaking into tests (#40689) (cherry picked from commit 3a510a2) --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Robo <hop2deep@gmail.com>
jkleinsc
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit 3a510a2)
jkleinsc
added a commit
that referenced
this pull request
Jan 29, 2024
* chore: [26-x-y] cherry-pick 2 changes from Release-0-M121 * cc07a95bc309 from chromium * test: fixup assertNotWindows (#41045) * chore: fixup assertNotWindows * remove logging (cherry picked from commit 3dafb31) * chore: cleanup global reject handler leaking into tests (#40689) (cherry picked from commit 3a510a2) --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Robo <hop2deep@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #40650 (comment)
Release Notes
Notes: no-notes