Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add E28 support for ESM in tutorial.md #40690

Merged
merged 1 commit into from Dec 4, 2023
Merged

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Dec 4, 2023

Description of Change

This PR updates our tutorial to include ESM support in Electron 28

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Dec 4, 2023
@VerteDinde VerteDinde added semver/none target/28-x-y PR should also be added to the "28-x-y" branch. and removed semver/patch backwards-compatible bug fixes labels Dec 4, 2023
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@VerteDinde VerteDinde changed the title docs: add E28 support for ESM in tutorial docs: add E28 support for ESM in tutorial.md Dec 4, 2023
@VerteDinde VerteDinde merged commit 9afeaa3 into main Dec 4, 2023
32 checks passed
@VerteDinde VerteDinde deleted the fix-esm-tutorial branch December 4, 2023 20:36
Copy link

release-clerk bot commented Dec 4, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Dec 4, 2023

I have automatically backported this PR to "28-x-y", please check out #40691

@trop trop bot added in-flight/28-x-y merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/28-x-y labels Dec 4, 2023
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
docs: add E28 support for ESM in tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/28-x-y PR was merged to the "28-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants