refactor: use base::NoDestructor instead of base::LazyInstance #40947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nMessageProvider()
…se_spellchecker_download_url.patch
ckerr
added
semver/patch
dsanders11
approved these changes
Jan 11, 2024
shell/browser/extensions/api/extension_action/extension_action_api.cc
Outdated
Show resolved
Hide resolved
deepak1556
reviewed
Jan 11, 2024
…rmissionMessageProvider() make sure instance is static
deepak1556
approved these changes
Jan 11, 2024
codebytere
deleted the
refactor/use-base-NoDestructor-not-base-LazyInstance
branch
|
No Release Notes |
This was referenced Jan 12, 2024
|
I have automatically backported this PR to "28-x-y", please check out #40978 |
trop
bot
added
in-flight/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #40979 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Second of a pair of PRs to stop using the deprecated class
base::LazyInstance. Its documentation says to usebase::NoDestructorinstead, so that's what this PR does.Any reviews welcomed. CC @codebytere and @miniak, who reviewed the previous #40927.
Checklist
npm testpassesRelease Notes
Notes: none