Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed typos and grammatical errors #40966

Merged
merged 3 commits into from Jan 19, 2024
Merged

docs: fixed typos and grammatical errors #40966

merged 3 commits into from Jan 19, 2024

Conversation

Villy-P
Copy link
Contributor

@Villy-P Villy-P commented Jan 11, 2024

Description of Change

Fixed typos and grammatical mistakes within the documentation, along with changing certain words to American English.

Checklist

  • npm test passes
  • relevant documentation, tutorials, templates and examples are changed or added

Release Notes

notes: none

Copy link

welcome bot commented Jan 11, 2024

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Jan 11, 2024
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Two comments, but we can merge with those are addressed

docs/tutorial/performance.md Outdated Show resolved Hide resolved
docs/tutorial/performance.md Outdated Show resolved Hide resolved
Villy-P and others added 2 commits January 11, 2024 15:11
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ckerr ckerr added the target/29-x-y PR should also be added to the "29-x-y" branch. label Jan 12, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 12, 2024
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙂

@Villy-P Villy-P changed the title docs: fixed typos docs: fixed typos and grammatical errors Jan 17, 2024
@ckerr ckerr merged commit 1300e83 into electron:main Jan 19, 2024
18 checks passed
Copy link

welcome bot commented Jan 19, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented Jan 19, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 19, 2024

I have automatically backported this PR to "29-x-y", please check out #41058

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants