refactor: inline simple getters #41163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
refactor: inline OffScreenRenderWidgetHostView::GetFrameRate() refactor: inline OffScreenRenderWidgetHostView::GetRootLayer() refactor: inline OffScreenRenderWidgetHostView::GetDelegatedFrameHost() Co-authored-by: Charles Kerr <charles@charleskerr.com>
refactor: inline OffscreenViewProxy::GetBounds() Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
refactor: inline RootView::is_menu_bar_visible() Co-authored-by: Charles Kerr <charles@charleskerr.com>
refactor: inline ElectronBrowserContext::get_max_cache_size() Co-authored-by: Charles Kerr <charles@charleskerr.com>
remove get_ prefix from inlined simple getter method names Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
…or() Co-authored-by: Charles Kerr <charles@charleskerr.com>
have object getters return const references Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
…rame_host() Co-authored-by: Charles Kerr <charles@charleskerr.com>
3 tasks
trop
bot
added
29-x-y
backport
ckerr
approved these changes
Jan 30, 2024
codebytere
deleted the
trop/29-x-y-bp-refactor-inline-simple-getters-1706582622265
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41125
See that PR for details.
Notes: none