refactor: use base::Value::Take*()

[ckerr]

Description of Change

Use base::Value::TakeDict(), TakeList(), and TakeString() where appropriate.

1. The docs recommend changing our current std::move(value.Get*()) to std::move(value).Take*() for better build-time checks.
2. In some cases, e.g. when we're pulling data out of a temporary base::Value::Dict, we can avoid extra work by Take*()ing objects directly from the temporary dict instead of copying them.

Description from values.h code comments:

// Transfers ownership of the underlying value. Similarly to Get...()
// variants above, fails with a CHECK() on a type mismatch. After
// transferring the ownership *this is in a valid, but unspecified, state.
// Prefer over std::move(value.Get...()) so clang-tidy can warn about
// potential use-after-move mistakes.
std::string TakeString() &&;
Dict TakeDict() &&;
List TakeList() &&;

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: none.

[codebytere]

@ckerr these two tests are failing consistently on macOS & Linux:

• protocol module protocol.registerSchemesAsPrivileged stream successfully plays videos when content is buffered (stream: false)
• protocol module protocol.registerSchemesAsPrivileged stream successfully plays videos when streaming content (stream: true)

Looks like this change inadvertently broke them somehow 🤔

[release-clerk]

No Release Notes