Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: type-safe module imports / requires #41192

Merged
merged 1 commit into from Feb 5, 2024
Merged

refactor: type-safe module imports / requires #41192

merged 1 commit into from Feb 5, 2024

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 31, 2024

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 31, 2024
@miniak miniak requested a review from ckerr January 31, 2024 10:41
@miniak miniak force-pushed the miniak/type-safe-imports branch 2 times, most recently from e8753c3 to 64504cf Compare January 31, 2024 10:52
@miniak miniak added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Jan 31, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 1, 2024
@miniak miniak requested a review from zcbenz February 1, 2024 22:13
ckerr
ckerr approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement!

@zcbenz zcbenz merged commit dac29f9 into main Feb 5, 2024
17 checks passed
@zcbenz zcbenz deleted the miniak/type-safe-imports branch February 5, 2024 07:36
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 5, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I have automatically backported this PR to "29-x-y", please check out #41235

@trop trop bot added the in-flight/29-x-y label Feb 5, 2024
@trop
Copy link
Contributor

trop bot commented Feb 5, 2024

I have automatically backported this PR to "28-x-y", please check out #41236

@trop trop bot added in-flight/28-x-y merged/29-x-y PR was merged to the "29-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/29-x-y labels Feb 5, 2024
@trop trop bot removed the in-flight/28-x-y label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @ckerr @jkleinsc @zcbenz