refactor: replace use of deprecated base::JSONWriter::WriteJson()
#41224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
refactor: use base::WriteJson() in DictionaryValueToNSDictionary() Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
3 tasks
trop
bot
added
28-x-y
backport
ckerr
force-pushed
the
trop/28-x-y-bp-refactor-replace-use-of-deprecated-base-jsonwriter-writejson--1706898373642
branch
from
767044e
to
22339a1
Compare
ckerr
requested changes
Feb 5, 2024
ckerr
force-pushed
the
trop/28-x-y-bp-refactor-replace-use-of-deprecated-base-jsonwriter-writejson--1706898373642
branch
from
83a73cc
to
22339a1
Compare
ckerr
approved these changes
Feb 5, 2024
This reverts commit cb6cfdf.
ckerr
approved these changes
Feb 5, 2024
|
|
|
Looks like these are coming back during a 3-way merge for some reason 🤔 |
|
Apparently the bots are doing the right thing? Looks like #41178 wasn't rebased on 28 for #41195, so those four commits are now upstream and the bots are correct to remove the patches. Thanks to @codebytere for spotting this; I didn't see it 😸 |
jkleinsc
approved these changes
Feb 5, 2024
ckerr
deleted the
trop/28-x-y-bp-refactor-replace-use-of-deprecated-base-jsonwriter-writejson--1706898373642
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41215
See that PR for details.
Notes: none