Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert refactor of non-deprecated NSKeyedArchiver APIs #41290

Merged
merged 1 commit into from Feb 9, 2024
Merged

fix: revert refactor of non-deprecated NSKeyedArchiver APIs #41290

merged 1 commit into from Feb 9, 2024

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Feb 8, 2024 •
edited by codebytere

Description of Change

This PR addresses a potential error with Squirrel's updater. Targeted at Electron 29 only. This reverts commit 514a931.

2024-02-08 13:17:34.613 ShipIt[18519:111971] Couldn't unarchive ownedBundle - The data couldn't be read because it isn't in the correct format.
2024-02-08 13:17:34.613 ShipIt[18519:111971] *** Assertion failure in -[SQRLInstaller deleteOwnedBundleAtURL:], SQRLInstaller.m:415
2024-02-08 13:17:34.617 ShipIt[18519:111971] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: bundleURL != nil'
*** First throw call stack:

As 29 is so close to stable and this will definitely affect other apps, revert until we can investigate more.

Checklist

Release Notes

Notes: Fixes a potential issue with Squirrel.Mac's updater and requiringSecureCoding.

@VerteDinde VerteDinde requested a review from a team as a code owner February 8, 2024 22:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2024
@VerteDinde VerteDinde added backport-check-skip Skip trop's backport validity checking 29-x-y semver/patch backwards-compatible bug fixes fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 8, 2024
@VerteDinde VerteDinde changed the title Fix: revert refactor of non-deprecated NSKeyedArchiver APIs fix: revert refactor of non-deprecated NSKeyedArchiver APIs Feb 8, 2024
@VerteDinde VerteDinde merged commit 432b894 into 29-x-y Feb 9, 2024
25 of 26 checks passed
@VerteDinde VerteDinde deleted the modify-archival-nskeyedarchiver-apis branch February 9, 2024 00:18
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 9, 2024

Release Notes Persisted

Fixes a potential issue with Squirrel.Mac's updater and requiringSecureCoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
29-x-y backport-check-skip Skip trop's backport validity checking fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VerteDinde @codebytere @erickzhao